Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print coverage statistics #172

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

ulucinar
Copy link
Contributor

@ulucinar ulucinar commented Nov 22, 2022

Description of your changes

Prints a coverage statistics line in the CI pipeline. Some previous discussions are here.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

A new step following the Check Diff step now prints the statistics in the CI Github workflow:
image

@ulucinar ulucinar marked this pull request as draft November 22, 2022 19:23
@ulucinar ulucinar force-pushed the report-statistics branch 3 times, most recently from 16634c7 to de28972 Compare November 22, 2022 19:33
@ulucinar ulucinar marked this pull request as ready for review November 23, 2022 13:39
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Copy link
Contributor

@ezgidemirel ezgidemirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ulucinar, LGTM

@ulucinar ulucinar merged commit 2ab8c1f into crossplane-contrib:main Nov 23, 2022
@ulucinar ulucinar deleted the report-statistics branch November 23, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants